Dataflow: Restrict partial flow to either forward or reverse flow.#14599
Dataflow: Restrict partial flow to either forward or reverse flow.#14599MathiasVP merged 3 commits intogithub:mainfrom
Conversation
MathiasVP
left a comment
There was a problem hiding this comment.
LGTM! I guess we should also update the reference to FlowExploration in https://codeql.github.com/docs/writing-codeql-queries/debugging-data-flow-queries-using-partial-flow/ (or make FlowExploration an alias for FlowExplorationFwd)?
The doc needs an update regardless as the info about reverse flow needs a fix. |
MathiasVP
left a comment
There was a problem hiding this comment.
The code changes LGTM! Should we have the Docs team 👀 the documentation changes?
It's very minor, so I think your review is plenty. |
|
Do you need to update the test queries in |
Gah! Of course CI didn't run. |
When using partial flow we would calculate both partial forward flow and partial reverse flow even though only one direction was requested. This moves the choice into the parameterised module application so we know up front which one to calculate. So instead of always using
module Partial = FlowExploration<limit/0>and choosing betweenPartial::partialFlowandPartial::partialFlowRev, you now choose betweenmodule Partial = FlowExplorationFwd<limit/0>andmodule Partial = FlowExplorationRev<limit/0>, and then always usePartial::partialFlow.